Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add cache option info to apollo-boost get started #3725

Merged
merged 4 commits into from
Jul 30, 2018
Merged

[docs] Add cache option info to apollo-boost get started #3725

merged 4 commits into from
Jul 30, 2018

Conversation

TheMightyPenguin
Copy link
Contributor

@TheMightyPenguin TheMightyPenguin commented Jul 23, 2018 •
edited
Loading

Adds info about the cache option on apollo-boost Get Started doc.

Support for this option was added in #3561 but it was not documented yet.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

@TheMightyPenguin
docs: Add cache option info to apollo-boost get started
b2a7e44 
Support for this option was added in [apollographql#3561](apollographql#3561) but it was not documented yet.
@ghost ghost added the 📝 documentation label Jul 23, 2018
@apollo-cla
Copy link

@TheMightyPenguin: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@ghost ghost added the 📝 documentation label Jul 23, 2018
@TheMightyPenguin TheMightyPenguin changed the title docs: Add cache option info to apollo-boost get started [docs] Add cache option info to apollo-boost get started Jul 23, 2018
@ghost ghost added the 📝 documentation label Jul 23, 2018
hwillson
hwillson approved these changes Jul 30, 2018
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @TheMightyPenguin - thanks!

@hwillson hwillson merged commit e97cf56 into apollographql:master Jul 30, 2018
@TheMightyPenguin TheMightyPenguin deleted the patch-1 branch July 31, 2018 03:49
@dependencies dependencies bot mentioned this pull request Aug 9, 2018
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees
No one assigned
Labels
📝 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheMightyPenguin @apollo-cla @hwillson