Update docs for meteor/apollo v3

[lorensr]

v3: apollographql/meteor-integration#124

Will release when this is merged. Maybe there's a better way to connect to WebApp, maybe @abernix knows? Currently recommending:

const server = new ApolloServer({...})

server.applyMiddleware({
  app: WebApp.connectHandlers,
  path: '/graphql'
})

// We are doing this work-around because Playground sets headers and WebApp also sets headers
// Resulting into a conflict and a server side exception of "Headers already sent"
WebApp.connectHandlers.use('/graphql', (req, res) => {
  if (req.method === 'GET') {
    res.end()
  }
})

[hwillson]

Thanks for this @lorensr! Actually, we've been talking about the Meteor integration docs a fair bit recently. Given that you're planning on releasing a 3.0.0 version of https://github.com/apollographql/meteor-integration, does that mean you (or someone else) will be supporting/maintaining it? We were under the impression that it is currently unmaintained (due to the repo's README), and we were planning on completely removing most of Apollo's Meteor integration section. We were going to instead replace that full section with a single page, that links to modern and maintained community approaches for integrating Meteor and Apollo. As things stand currently, our preference is to point people towards using https://github.com/Swydo/ddp-apollo, since it's actively maintained. If someone is taking over the apollo package though, great!

So long story short - if the apollo package is going to be maintained by someone, we'll definitely get these changes merged in. If it's not though, we're likely moving ahead with reducing this section greatly. Let me know - thanks!

[lorensr]

Happy to keep maintaining it, and to direct people to @Swydo—lmk if there are other differences I should note in the beginning of the docs

…

On Tue, Jul 31, 2018 at 10:40 AM Hugh Willson ***@***.***> wrote: Thanks for this @lorensr <https://github.com/lorensr>! Actually, we've been talking about the Meteor integration docs a fair bit recently. Given that you're planning on releasing a 3.0.0 version of https://github.com/apollographql/meteor-integration, does that mean you (or someone else) will be supporting/maintaining it? We were under the impression that it is currently unmaintained (due to the repo's README), and we were planning on completely removing most of Apollo's Meteor integration section. We were going to instead replace that full section with a single page, that links to modern and maintained community approaches for integrating Meteor and Apollo. As things stand currently, our preference is to point people towards using https://github.com/Swydo/ddp-apollo, since it's actively maintained. If someone is taking over the apollo package though, great! So long story short - if the apollo package is going to be maintained by someone, we'll definitely get these changes merged in. If it's not though, we're likely moving ahead with reducing this section greatly. Let me know - thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3739 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPVmKTxb9SrUz653rq9z2cfDIJYLFzzks5uMGxGgaJpZM4Vg_NE> .

[hwillson]

Okay, thanks @lorensr. I'll add a few adjustments here (and will likely remove the subscriptions section completely since SubscriptionManager has been deprecated), then get this in place.

@theodorDiaconu I know you're doing a lot of interesting things with regards to Meteor + Apollo integration. Once we have this section cleaned up a bit, if you're interested in adding a reference to your https://github.com/cult-of-coders/apollo project, let me know. Thanks!

[theodorDiaconu]

@hwillson can you define what kind of reference you mean ?

[hwillson]

@theodorDiaconu I just meant that in the Meteor + Apollo section, we're mentioning the apollo package and swydo:ddp-apollo. If you would like us to add a link to your https://github.com/cult-of-coders/apollo project as well, let us know.

[lorensr]

@hwillson v3 of meteor/apollo has been published

[tab00]

Good work with the new content so far, guys. It has been much needed.

You can remove the instructions to install graphql-playground as it's now automatically installed. You can simply load it in the browser with /graphql path.

Please update the Subscriptions section to show new syntax and examples (that work) with WebSocketLink and without SubscriptionManager, or SubscriptionServer, as I've been having trouble getting it working and have been looking around.

Thank you.

[tab00]

I think I've worked out how to do Subscriptions client-side. Feel free to use this to replace the old code.

import ApolloClient from 'apollo-client'
import { ApolloLink } from 'apollo-link'
import { MeteorAccountsLink } from 'meteor/apollo'
import { HttpLink } from 'apollo-link-http'
import { WebSocketLink } from 'apollo-link-ws'
import { InMemoryCache } from 'apollo-cache-inmemory'

const apolloClient = new ApolloClient({
  link: ApolloLink.split( // split based on operation type
    ({ query }) => {
      import { getMainDefinition } from 'apollo-utilities'
      const { kind, operation } = getMainDefinition(query)
      return kind === 'OperationDefinition' && operation === 'subscription'
    },
    new WebSocketLink({
      uri: `ws://localhost:3000/subscriptions`,
      options: { reconnect: true }
    }),
    ApolloLink.from([
      new MeteorAccountsLink(),
      new HttpLink({ uri: '/graphql' })
    ]),
  ),
  cache: new InMemoryCache()
})


import { ApolloProvider, Subscription } from "react-apollo"
import gql from 'graphql-tag'

return (
  <React.StrictMode>
    <ApolloProvider client={apolloClient}>
      <Subscription
        subscription={gql`
              subscription onCommentAdded($repoFullName: String!){
                commentAdded(repoFullName: $repoFullName){
                  id
                  content
                }
              }`}

        variables={{ repoFullName: "full name" }}
      >
        {({ data, loading, error }) => {
          if (loading) return null
          if (error) console.log(`Subscription error: ${JSON.stringify(error)}`)
          else console.log(`New data from subscription: ${JSON.stringify(data)}`)
          return JSON.stringify(data)
        }}
      </Subscription>
    </ApolloProvider>
  </React.StrictMode>
)

[tab00]

Can we see some working code for using the built-in subscription server in Apollo Server? I've been having some trouble. See my code at apollographql/apollo-server#1537

[hwillson]

Thanks for working on this @lorensr!

[hwillson]

I'm going to merge this as is. @tab00, any chance you'd like to create a separate PR with the subscription section changes? Thanks all!