Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node 5 from tests to speed things up #386

Merged
merged 2 commits into from
Jul 11, 2016
Merged

Remove node 5 from tests to speed things up #386

merged 2 commits into from
Jul 11, 2016

Conversation

stubailo
Copy link
Contributor

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

I've never seen something pass in 4 and 6 but fail in 5, and nobody should be using 5 anyway since it's not LTS or the latest stable.

Remove node 5 from tests to speed things up
483ed78 
I've never seen something pass in 4 and 6 but fail in 5, and nobody should be using 5 anyway since it's not LTS or the latest stable.
@stubailo stubailo merged commit 97e0e81 into master Jul 11, 2016
@zol zol removed the in progress label Jul 11, 2016
@stubailo stubailo deleted the stubailo-patch-3 branch September 20, 2016 03:41
@snyk-bot snyk-bot mentioned this pull request Jul 20, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Feb 21, 2022
Open
@NOUIY NOUIY mentioned this pull request Apr 21, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stubailo @zol