Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffQueryAgainsStore set returnPartialData to false #4042

Closed
wants to merge 1 commit into from

Conversation

quazzie
Copy link
Contributor

@quazzie quazzie commented Oct 24, 2018

Is there a reason why returnPartialData is true?
This was hiding an error and returning { data: undefined, networkState: 7, stale: true } for me.
I had forgotten to query for the id of an object and watchQuery could not find it in store.
With returnPartialData false i was able to get an error about missing property and finally find the problem.
With this true all i was getting from watchQuery was { data: undefined, networkState: 7, stale: true }.

Maybe related issues: #3030 , #2914

Is there a reason why returnPartialData is true?
This was hiding an error and returning { data: undefined, networkState: 7, stale: true } for me.
I had forgotten to query for the id of an object and watchQuery could not find it in store.
With returnPartialData false i was able to get an error about missing property and finally find the problem.
With this true all i was getting from watchQuery was { data: undefined, networkState: 7, stale: true }.

Maybe related issues: apollographql#3030 , apollographql#2914
@quazzie quazzie closed this Oct 25, 2018
@quazzie quazzie deleted the patch-3 branch October 25, 2018 13:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant