Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(subscriptions.md): remove "required" marker from children prop #4179

Merged
merged 2 commits into from
Jan 2, 2019
Merged

docs(subscriptions.md): remove "required" marker from children prop #4179

merged 2 commits into from
Jan 2, 2019

Conversation

jedwards1211
Copy link
Contributor

children is no longer required: https://github.com/apollographql/react-apollo/blob/master/src/Subscriptions.tsx#L32

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

hwillson
hwillson approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @jedwards1211 - thanks!

@hwillson hwillson merged commit c24b11c into apollographql:master Jan 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

@benjamn benjamn Awaiting requested review from benjamn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedwards1211 @hwillson