Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complete handler in startGraphQLSubscription #4290

Merged
merged 4 commits into from
Jan 9, 2019

Conversation

sujeetsr
Copy link
Contributor

@sujeetsr sujeetsr commented Jan 7, 2019

Handle subscription completion, for the case of finite subscriptions
(apollographql/subscriptions-transport-ws#471)
@hwillson - Please review

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@sujeetsr sujeetsr requested a review from benjamn as a code owner January 7, 2019 21:29
@apollo-cla
Copy link

@sujeetsr: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@sujeetsr
Copy link
Contributor Author

sujeetsr commented Jan 7, 2019

Sample client and server app to test this: https://github.com/sujeetsr/subscriptions-example

@hwillson hwillson self-assigned this Jan 9, 2019
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @sujeetsr - thanks very much!

@hwillson hwillson merged commit b91414f into apollographql:master Jan 9, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants