Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update optimism to use its new TypeScript declarations. #4331

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Jan 18, 2019

Since we've been struggling to declare correct types for the optimism npm package (for example: #4158, #4327), I finally decided to move the declarations into the optimism package itself: benjamn/optimism@03b3f88

Pretty easy! I wish I'd done this sooner.

Should fix #4327.

Verified

This commit was signed with the committer’s verified signature.
benjamn Ben Newman
Wow, I should have done this sooner. Super simple:
benjamn/optimism@03b3f88

Follow-up to #4158.
Should fix #4327.

Verified

This commit was signed with the committer’s verified signature.
benjamn Ben Newman
@benjamn benjamn merged commit 72c5587 into master Jan 18, 2019
@benjamn benjamn deleted the use-types-provided-by-optimism branch January 18, 2019 17:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing types for 'optimism' npm package in apollo-cache-inmemory.
1 participant