Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a section about react native debugger support for apollo dev tools #4386

Merged
merged 3 commits into from
Feb 2, 2019

Conversation

Gongreg
Copy link
Contributor

@Gongreg Gongreg commented Jan 30, 2019

Apollo dev tools were just merged into master of react native debugger.
jhen0409/react-native-debugger#298

@peggyrayzis suggested to add a section about it in Apollo documentation.

The updated React Native Debugger is not released for download, but it will be done soon.

@danilobuerger
Copy link
Contributor

🙌Let's wait until its released before merging this.

@danilobuerger danilobuerger self-assigned this Jan 30, 2019
@Gongreg
Copy link
Contributor Author

Gongreg commented Jan 30, 2019

Sure @danilobuerger, just added it since I had some time to burn :)

There is one "annoying" feature of Apollo dev tools is that it stops trying to connect after 10 seconds. Not sure if we need to write about it here. To avoid explaining it I just wrote step 3 (turn off and on again).

@danilobuerger
Copy link
Contributor

Alright, thanks for the heads up. I will check it out once its released and take a look.

@jhen0409
Copy link

jhen0409 commented Feb 1, 2019

Hey @danilobuerger and @Gongreg, I already released the new version of react-native-debugger. Sorry for a little delay.

@Gongreg
Copy link
Contributor Author

Gongreg commented Feb 1, 2019

@danilobuerger, dev tools version 0.9.0.
I am really happy to finally get it out :)

@danilobuerger
Copy link
Contributor

@Gongreg @jhen0409 Thanks for your awesome work. However, I can't get this to work yet. I don't feel comfortable merging this yet when I am not able to follow the instructions. I will post on your issue tracker to avoid going off topic in this issue.

@derekr
Copy link

derekr commented Feb 1, 2019

I have it working for me following the instructions FWIW. I did have to toggle developer tools off and on. Super excited about this addition. Thank you!

@danilobuerger
Copy link
Contributor

With the release of 0.9.2 my issue has been fixed and I was able to test the instructions.

@danilobuerger danilobuerger merged commit 2a05514 into apollographql:master Feb 2, 2019
@danilobuerger
Copy link
Contributor

Thanks @Gongreg

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants