Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to GlobalFetch in Typescript #5373

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Remove reference to GlobalFetch in Typescript #5373

merged 2 commits into from
Dec 13, 2019

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented Sep 26, 2019 •
edited
Loading

The same PR as apollographql/apollo-link#1095 for apollo-boost.

Fix #5367

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

This was referenced Sep 26, 2019
Closed
Closed
@abdonrd abdonrd force-pushed the abdonrd-patch-1 branch 2 times, most recently from 7a419c6 to 528da14 Compare October 3, 2019 17:11
@abdonrd abdonrd force-pushed the abdonrd-patch-1 branch 2 times, most recently from 86f17dd to 773cf13 Compare October 8, 2019 20:46
@abdonrd abdonrd force-pushed the abdonrd-patch-1 branch 2 times, most recently from 818a420 to a597ff5 Compare October 17, 2019 08:43
malinsan added a commit to malinsan/apollo-client that referenced this pull request Oct 29, 2019
@malinsan
Fix global fetch bug e.g issue apollographql#5373
446ba05
@abdonrd abdonrd mentioned this pull request Oct 29, 2019
Closed
@abdonrd abdonrd mentioned this pull request Nov 13, 2019
Closed
2 tasks
@abdonrd abdonrd force-pushed the abdonrd-patch-1 branch 3 times, most recently from 6c96d65 to d9fcdeb Compare November 20, 2019 08:53
@abdonrd
Copy link
Contributor Author

abdonrd commented Nov 20, 2019

Friendly ping to @benjamn! 🙏

@danlourenco
Copy link

What's the hold up on this one? We can't update our project to TS 3.7.3 until this issue is resolved.

@ecrofeg
Copy link

ecrofeg commented Dec 12, 2019

@StephenBarlow 🙏 we're stuck on TS 3.5 because of this :(

@abdonrd
Copy link
Contributor Author

abdonrd commented Dec 13, 2019

Rebased on master!

hwillson
hwillson approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @abdonrd, and sorry about the delay! We'll get this merged, but just a quick heads up - Apollo Boost is being deprecated, and will not be part of Apollo Client 3 (all of Boost's capabilities will be baked right into the Apollo Client core). Thanks again!

@hwillson hwillson merged commit 362e465 into apollographql:master Dec 13, 2019
@abdonrd abdonrd deleted the abdonrd-patch-1 branch December 13, 2019 11:21
@abdonrd
Copy link
Contributor Author

abdonrd commented Dec 13, 2019

Thanks @hwillson! Can we spect a patch release soon? 🙏

( And yes! I look forward to v3 final release! )

@hwillson
Copy link
Member

@abdonrd It should be available now: https://github.com/apollographql/apollo-client/releases/tag/v2.6.8

@abdonrd
Copy link
Contributor Author

abdonrd commented Dec 14, 2019

Great, thanks @hwillson!

@snyk-bot snyk-bot mentioned this pull request Jan 17, 2020
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

@bwlt bwlt bwlt approved these changes

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apollo Boost incompatible with TypeScript 3.6
5 participants
@abdonrd @danlourenco @ecrofeg @hwillson @bwlt