Export utilities via @apollo/client/utilities #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
force-pushed
the
utilities-entry-point
branch
from
06a79c0 to
49f28ad
Compare
hwillson
commented
Dec 13, 2019
Comment on lines
+111
to
+127
| function prepareUtilities() { | ||
| const utilsDistDir = `${distDir}/utilities`; | ||
| return { | ||
| input: `${utilsDistDir}/index.js`, | ||
| external, | ||
| output: { | ||
| file: `${utilsDistDir}/utilities.cjs.js`, | ||
| format: 'cjs', | ||
| sourcemap: true, | ||
| exports: 'named', | ||
| }, | ||
| plugins: [ | ||
| nodeResolve(), | ||
| ], | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
We can't follow our usual approach of creating a file that just re-exports only the items it needs from the main apollo-client.cjs.js bundle, as we aren't exporting utilities in apollo-client.cjs.js. Here we're building a separate utilities.cjs.js bundle instead.
There was a problem hiding this comment.
Yep, makes sense. Even easier this way.
hwillson
force-pushed
the
utilities-entry-point
branch
from
118b487 to
87c7a2b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With AC 3 (
@apollo/client) we're no longer exporting the utilities that were previously available viaapollo-utilities. While not exporting them from the main bundle is intentional, there is value in being able to access some of these utilities directly. This PR creates a new@apollo/client/utilitiesentry point, and makes many of AC 3's internal utilities externally accessible. E.g.:This PR also tackles cleaning up / removing some of the utilities that AC 3 no longer uses.