Simplify EntityStore#merge. #5904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to EntityStore#merge by itself caused an esoteric test failure in src/cache/inmemory/__tests__/optimistic.ts, but I was able to fix that by addressing an old TODO in Layer#removeLayer.
Replacing a Reference in the cache is always safe, even with non-normalized data, since the Reference refers to data safely stored elsewhere in the cache. By removing this invariant, we remove the need for most of the surrounding logic in the storeObjectReconciler function, too, which is why it can be so much shorter now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More meaningful warnings are coming (#5833) when merging non-normalized data in the cache, and we can save some code by not worrying about edge cases that don't matter.