test: add test case for reproducible bug #6059
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case for apollographql/react-apollo#3425. This is intended to fail as it is trying to reproduce the bug.
Context
Despite an update occurring, this bug causes the query's
loading
to remaintrue
. It happens when we:a
.b
. This query's result is the same as step 1's result.Tracing this bug
This is roughly the call stack for step 3 mentioned above:
map
andcomplete
callbacks are calledobserver
'snext
is calledNote that since the new and old data is the same despite having different query variables, step 11 ObservableQuery's
isDifferentFromLastResult
will returnfalse
.This causes the ObservableQuery's
observers
' to not be called. QueryData'scurrentObservable.subscription
does not trigger and the component does not update.Fixing the bug
This is where I need help. I am not sure what would be the proper fix. Here a few ideas:
previousVariables
toObservableQuery
and compare them inisDifferentFromLastResult
complete