Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default args.offset to 0 in offsetLimitPagination. #7141

Merged
merged 2 commits into from
Oct 10, 2020
Merged

Default args.offset to 0 in offsetLimitPagination. #7141

merged 2 commits into from
Oct 10, 2020

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Oct 9, 2020

This makes the field policy returned by offsetLimitPagination tolerant of a missing args.offset, by defaulting it to 0. Motivating discussion: #7135 (comment).

@benjamn benjamn added this to the Post 3.0 milestone Oct 9, 2020
@benjamn benjamn requested review from hwillson and jcreighton October 9, 2020 21:59
@benjamn benjamn self-assigned this Oct 9, 2020
@benjamn benjamn force-pushed the default-offset-for-offsetLimitPagination branch from 68e8b87 to e4202b9 Compare October 9, 2020 22:08
@benjamn benjamn merged commit 8e92be3 into main Oct 10, 2020
@benjamn benjamn deleted the default-offset-for-offsetLimitPagination branch October 10, 2020 17:21
hwillson
hwillson reviewed Oct 10, 2020
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm late to the party, but looks great @benjamn!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson left review comments

@jcreighton jcreighton Awaiting requested review from jcreighton

Assignees

@benjamn benjamn

Labels
🧞‍♂️ enhancement 🔠 quick-and-easy
Projects
None yet
Milestone
Post 3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@benjamn @hwillson