Call this.currentObservable.tearDownQuery more consistently. #7259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #7205, per my comment in #7254: #7254 (comment) Instead of tearing down this.currentObservable only when this.getOptions().skip is true in QueryData#removeQuerySubscription, I split the tear-down functionality into a separate private method (QueryData#removeObservable), which is now called everywhere removeQuerySubscription is called, except in resubscribeToQuery, where we specifically want to preserve this.observableQuery.
benjamn
commented
Oct 29, 2020
| @@ -63,6 +63,7 @@ export class QueryData<TData, TVariables> extends OperationData { | |||
| const { skip, query } = this.getOptions(); | |||
| if (skip || query !== this.previous.query) { | |||
| this.removeQuerySubscription(); | |||
| this.removeObservable(!skip); | |||
There was a problem hiding this comment.
When skip is true, this code passes false to this.removeObservable, so that this.currentObservable will not be deleted after being torn down, so we can restart it later (once skip is no longer true).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #7205, per my comment #7254 (comment).
Instead of tearing down
queryData.currentObservableonly whenqueryData.getOptions().skipis true inremoveQuerySubscription(which was the idea of #7205), I split the tear-down functionality into a separate private method (removeObservable), which works regardless of theskipstatus, and is called everywhereremoveQuerySubscriptionis called, except inresubscribeToQuery, where we specifically want to preservethis.observableQuery.