Always consider ROOT_{QUERY,MUTATION,...} IDs to be GC roots. #7333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hwillson @jcreighton On second thought, I'd like to get this mitigation out ASAP in v3.2.6, and do the rest of the work (preserving |
benjamn
added a commit
that referenced
this pull request
Nov 16, 2020
benjamn
force-pushed
the
7323-restore-gc-root-ids
branch
from
7dc33c5 to
a2ab26b
Compare
benjamn
added a commit
that referenced
this pull request
Nov 16, 2020
benjamn
force-pushed
the
7323-restore-gc-root-ids
branch
from
a2ab26b to
28e0d6e
Compare
Partial solution for #7323, as we still need to decide the best way to persist retainment counts for non-ROOT_* entity objects written directly with cache.writeFragment.
benjamn
force-pushed
the
7323-restore-gc-root-ids
branch
from
3d1a517 to
8fa17f5
Compare
This was referenced Nov 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial solution for #7323, as we still need to decide the best way to persist retainment counts for non-
ROOT_*entity objects written directly withcache.writeFragment.