Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): update dependency symbol-observable to v3 (#7299)" #7340

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Nov 17, 2020

This reverts commit 2809d6d, hopefully fixing issue #7337. The problem is not the @types/node version, as conjectured in #7335, but the incompatibility between the version of @types/node used by Angular and the major update of symbol-observable, which is a non-dev dependency of @apollo/client:

ERROR in node_modules/@apollo/client/node_modules/symbol-observable/index.d.ts:6:14 - error TS2717: Subsequent property declarations must have the same type.  Property 'observable' must be of type 'symbol', but here has type 'unique symbol'.

    6     readonly observable: unique symbol;
                   ~~~~~~~~~~

      node_modules/@types/node/globals.d.ts:146:14
        146     readonly observable: symbol;
                         ~~~~~~~~~~
        'observable' was also declared here.

@benjamn benjamn requested a review from hwillson November 17, 2020 14:56
@benjamn
Copy link
Member Author

benjamn commented Nov 17, 2020

Thanks to @matt-goldman's reproduction steps in #7337, I can confirm that this PR fixes the problem.

@benjamn benjamn merged commit 82c59a3 into main Nov 17, 2020
@benjamn benjamn deleted the revert-symbol-observable-v3-update branch November 17, 2020 15:24
@benjamn benjamn self-assigned this Nov 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant