Cancel queryInfo.notifyTimeout when marking final results. #7347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the reproduction in #7346 demonstrates, it was possible for the
QueryInfo#notify
timeout set inQueryInfo#setDiff
on behalf of an earlierloading: true
result to fire after the finalloading: false
result had been recorded inQueryInfo#markResult
, which could lead to unnecessary network requests when using aFetchPolicy
ofcache-and-network
ornetwork-only
, especially when there are multipleuseQuery
calls in the same React component.This PR fixes that problem by canceling the timeout in
QueryInfo#markResult
andmarkError
, since those methods are called by code that delivers the results through other mechanisms.