Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set displayName for ApolloContext #7550

Merged
merged 2 commits into from
Jan 11, 2021
Merged

set displayName for ApolloContext #7550

merged 2 commits into from
Jan 11, 2021

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Jan 6, 2021

This PR sets displayName for ApolloContext so that it'll render ApolloContext.Provider instead of Context.Provider in React Devtools.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@dulmandakh: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea! Thanks @dulmandakh.

@benjamn benjamn merged commit 4a5822a into apollographql:main Jan 11, 2021
benjamn added a commit that referenced this pull request Jan 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants