Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/fix failing test of reading cache data immediately during server-side rendering. #7983

Merged
merged 4 commits into from
Apr 13, 2021
Merged

Add/fix failing test of reading cache data immediately during server-side rendering. #7983

merged 4 commits into from
Apr 13, 2021

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Apr 13, 2021

This failing test was inspired by a reproduction provided by @bwhitty. The bug it demonstrates is that, during server-side rendering, useQuery always returns a loading: true result when first called, even if the cache already contains the necessary data to provide a final loading: false result.

@benjamn benjamn self-assigned this Apr 13, 2021
@benjamn benjamn requested review from brainkim and jcreighton April 13, 2021 21:10
@benjamn benjamn changed the title Add failing test of reading cache data immediately during server-side rendering. Add/fix failing test of reading cache data immediately during server-side rendering. Apr 13, 2021
bwhitty
bwhitty approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@bwhitty bwhitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @benjamn for the quick turnaround! Huge help in unblocking us 🎉

@benjamn benjamn merged commit 3ca573c into main Apr 13, 2021
@benjamn benjamn deleted the useQuery-SSR-loading-true-initial-result branch April 13, 2021 21:32
@benjamn benjamn mentioned this pull request Apr 13, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcreighton jcreighton jcreighton approved these changes

@brainkim brainkim brainkim approved these changes

@bwhitty bwhitty bwhitty approved these changes

Assignees

@benjamn benjamn

Labels
💸 caching 🧪 has-tests ⚛️ React-related 📟 regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjamn @bwhitty @brainkim @jcreighton