Delay initializing stringifyCanon until canonicalStringify used.
#8558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likely related: apollographql/react-apollo-error-template#51 (comment) |
benjamn
added a commit
that referenced
this pull request
Jul 29, 2021
This will allow us to release the changes from PR #8558 in a beta release before merging them to main and publishing v3.4.1.
|
lgtm |
brainkim
approved these changes
Jul 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May help with #8557, because initializing
let stringifyCanon = new ObjectCanonin module scope led to evaluating the__DEV__global variable before it had been polyfilled (that's my current theory, at least).Background reading:
__DEV__: Use__DEV__internally instead ofprocess.env.NODE_ENV. #8347canonicalStringify: Remove dependency onfast-json-stable-stringify#8222