Ensure cache.broadcastWatch passes all relevant WatchOptions to cache.diff
#8832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
added
2021-09
⛑ TypeScript
🐞 bug
👩🔬 needs-more-tests
💸 caching
🧪 has-tests
and removed
👩🔬 needs-more-tests
labels
benjamn
force-pushed
the
pass-all-relevant-diff-options-in-broadcastWatch
branch
from
d47ce83 to
eb3c7c8
Compare
|
Thanks for all of the great (and fast!) work around canonization, including the pivot on the default value. Great job. |
Both `returnPartialData` and `canonizeResults` were missing from this call. Instead of enumerating the properties, we can take advantage of the overlap between `WatchOptions` and `DiffOptions` to pass all properties through, without having to enumerate them explicitly, so this kind of mistake won't happen again. Fixes #8831.
benjamn
force-pushed
the
pass-all-relevant-diff-options-in-broadcastWatch
branch
from
eb3c7c8 to
6c5e771
Compare
benjamn
deleted the
pass-all-relevant-diff-options-in-broadcastWatch
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @aj-foster noticed in #8831,
canonizeResults(and alsoreturnPartialData!) were missing from thiscache.diffcall.Instead of enumerating the missing properties explicitly, we can take advantage of the overlap between
WatchOptionsandDiffOptionsto pass all relevant properties through, so this kind of mistake won't happen again.Fixes #8831.