Refactor to avoid import cycle between inMemoryCache.ts and readFromStore.ts
#8850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
commented
Sep 27, 2021
Comment on lines
23
to
25
| export { | ||
| InMemoryCache, | ||
| InMemoryCacheConfig, | ||
| } from './inmemory/inMemoryCache'; |
There was a problem hiding this comment.
InMemoryCacheConfig is now exported by the
export * from './inmemory/types';line below.
benjamn
commented
Sep 27, 2021
| } from '../../utilities'; | ||
|
|
||
| export const { | ||
| hasOwnProperty: hasOwn, | ||
| } = Object.prototype; | ||
|
|
||
| export function defaultDataIdFromObject( |
There was a problem hiding this comment.
Moved defaultDataIdFromObject here to prevent another dependency cycle between helpers.ts and policies.ts.
benjamn
commented
Sep 27, 2021
| return compact(defaultConfig, config); | ||
| } | ||
|
|
||
| export function shouldCanonizeResults( |
There was a problem hiding this comment.
The shouldCanonizeResults helper now lives in helpers.ts, whence it can be non-circularly imported by both inMemoryCache.ts and readFromStore.ts.
brainkim
approved these changes
Sep 27, 2021
benjamn
deleted the
refactor-to-avoid-InMemoryCache-StoreWriter-import-cycle
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
shouldCanonizeResultshelper function introduced in #8822 was defined ininMemoryCache.tsbut also used inreadFromStore.ts. Since these two modules already mutually import TypeScript types from each other, the addition of a concrete/value export caused Rollup to begin displaying a warning about the new dependency cycle:Dependency cycles in JavaScript are generally harmless and often unavoidable, but we can simplify the work of bundlers like Rollup by eliminating the cycles that are avoidable (as this one is).