-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: onCompleted not updating regression #9226
fix: onCompleted not updating regression #9226
Conversation
cc @brainkim as your change caused the regression |
We detected the same regression and without this fix we are not able to update to update Apollo and to update GraphQL with version 16. All forms are not working anymore. And I'm a little bit afraid to wait long time when I see all pull requests open. This fix must be treated with a higher priority. |
Tbh it's super disappointing this has been open for a while and no attention.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for diagnosing/fixing/testing this, and sorry for the wait @mmahalwy!
@mmahalwy Thanks for this! |
7ba6b6b
to
c1deb4f
Compare
@mmahalwy oh my, great find - THANK YOU! |
Thank you for this fix. I think this error was also affecting
on call on move on to the version |
Fixes regression caused by:
f1a9770#diff-fb7fa652de6d84c08b87344a06a4d120b664c6e8bf491d16575794c755141477R136-R142
I tested this on 3.4.0 and it works as expected. This broke on 3.5.x. I think it's also related to this issue but for queries.
I also wrote the tests and confirmed that tests were failing prior to my change.
Checklist: