Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct useLazyQuery types #9304

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Correct useLazyQuery types #9304

merged 1 commit into from
Jan 19, 2022

Conversation

sztadii
Copy link
Contributor

@sztadii sztadii commented Jan 13, 2022

I forked the repo because I was going to improve the error message of MockProvider,
but I realized that the latest version will give enough details, so I do not need to improve anything.
I walk around and I found one TODO, so I thought I will help with that.

@apollo-cla
Copy link

@sztadii: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@sztadii
Copy link
Contributor Author

sztadii commented Jan 13, 2022

@benjamn looks like it is failing because of this PR #9287

@sztadii
Copy link
Contributor Author

sztadii commented Jan 13, 2022

@benjamn looks like this PR #9287 needs to be reverted. There many many plugins incompatible with version 3.0.0.
To merge this PR I created the branch from the last working commit.
Probably your team need to discuss #9287

@sztadii
Copy link
Contributor Author

sztadii commented Jan 18, 2022

@benjamn can you look at this PR or assign someone who can approve it?

@benjamn benjamn requested review from brainkim and benjamn January 18, 2022 17:22
@benjamn
Copy link
Member

benjamn commented Jan 18, 2022

@sztadii Thanks for flagging this. I will bring the reversion of #9287 up at today's team meeting.

@sztadii
Copy link
Contributor Author

sztadii commented Jan 19, 2022

@benjamn @brainkim I think we should revert that #9287, cause the number of PR is increasing.
I think ignoring the CI will only make new issues :(

@sztadii
Copy link
Contributor Author

sztadii commented Jan 19, 2022

@benjamn @brainkim it looks like this PR will solve 2 issues 🥳 #9116 and #9102.

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @sztadii!

@benjamn benjamn merged commit 50ca93e into apollographql:main Jan 19, 2022
@sztadii sztadii deleted the correct-useLazyQuery-types branch January 19, 2022 20:26
@benjamn
Copy link
Member

benjamn commented Jan 20, 2022

@sztadii The accidental gatsby@3 update has been reverted in #9329. That seems to fix the docs/Netlify-related tests, but let us know if anything is still broken for you. Thanks!

@benjamn benjamn added this to the v3.5.x patch releases milestone Jan 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants