Hotfixes #9328
Merged
Hotfixes #9328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainkim
force-pushed
the
brian-3.5-triage-2
branch
from
78c136a to
f44ab99
Compare
sztadii
reviewed
Jan 19, 2022
sztadii
reviewed
Jan 19, 2022
Comment on lines
+424
to
+426
| expect(errorMock).toHaveBeenCalledTimes(1); | ||
| expect(errorMock.mock.calls[0][0]).toMatch("Missing field"); | ||
| errorMock.mockRestore(); |
There was a problem hiding this comment.
I think we should not do the below assertions
expect(errorMock).toHaveBeenCalledTimes(1);
expect(errorMock.mock.calls[0][0]).toMatch("Missing field");
Those elements are part of validation that is not tested here.
Otherwise if someday we will going to change the validation message from
Missing field to The field "name" is missing we will need to update much more tests.
There was a problem hiding this comment.
This is mostly a sanity check to make sure another error hasn’t snuck into the test. The tests would definitely fail if we changed the error message but I’m okay with it because that would be a quick fix.
benjamn
force-pushed
the
brian-3.5-triage-2
branch
from
4e72cbb to
8e0e7a2
Compare
brainkim
force-pushed
the
brian-3.5-triage-2
branch
from
8e0e7a2 to
0733117
Compare
brainkim
force-pushed
the
brian-3.5-triage-2
branch
from
0733117 to
d9f096e
Compare
|
thanks for the stale variables fix, this was driving me crazy and I was thinking it was me. |
This was referenced Jan 31, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by commit.
Fixes #9101, #9129, #9142.
As a way to simplify
useLazyQuery(), we are now using theskip: true/refetch pattern described in #9101 to defineuseLazyQuery(), which should give ususeMutation()like error behavior.useEffect()just should not be trusted to do anything at all.