Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build config to work on Windows #9805

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

dylanwulf
Copy link
Contributor

Fix the build config to work on Windows.
The changes to rollup.config.js resulted from this discussion (almost a year ago!): #8341 (comment)
The changes to helpers.ts and rewriteSourceMaps.ts were needed because the glob package no longer supports backslashes as path separators in v8.0: https://github.com/isaacs/node-glob/blob/main/changelog.md#80

@dylanwulf dylanwulf force-pushed the fix-windows-build branch from 2489b58 to 8ef4bc3 Compare June 10, 2022 17:07
@jpvajda jpvajda added the 🏓 awaiting-team-response requires input from the apollo team label Jun 10, 2022
@jpvajda jpvajda requested a review from benjamn June 10, 2022 21:57
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, though I admit I have not run it myself on Windows. Thanks for keeping an eye on this @dylanwulf!

@benjamn benjamn added 🛠 tooling and removed 🏓 awaiting-team-response requires input from the apollo team labels Jun 10, 2022
@benjamn benjamn added this to the v3.6.x patch releases milestone Jun 10, 2022
@benjamn benjamn force-pushed the fix-windows-build branch from c677068 to 9f76033 Compare June 10, 2022 22:33
@benjamn benjamn merged commit 04dcd30 into apollographql:main Jun 10, 2022
@dylanwulf dylanwulf deleted the fix-windows-build branch June 10, 2022 22:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants