Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ID scalar as a custom scalar #363

Merged
merged 5 commits into from
May 20, 2024
Merged

Support ID scalar as a custom scalar #363

merged 5 commits into from
May 20, 2024

Conversation

AnthonyMDev
Copy link
Contributor

This changes the generation of the ID scalar to be treated as a custom scalar that can be modified by the user.

This is implemented by request from #3379.

@AnthonyMDev AnthonyMDev linked an issue May 17, 2024 that may be closed by this pull request
Copy link

netlify bot commented May 17, 2024

Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit ce755b2
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/664ba32714eca500089d7677

Copy link

netlify bot commented May 17, 2024

Deploy Preview for apollo-ios-docc canceled.

Name Link
🔨 Latest commit ce755b2
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docc/deploys/664ba3270b847d00085939db

@calvincestari
Copy link
Member

This looks good, thanks for doing it so quickly. It seems to be failing on one of the codegen test configurations though. 🤔

@AnthonyMDev AnthonyMDev merged commit fa96fa4 into main May 20, 2024
24 checks passed
@AnthonyMDev AnthonyMDev deleted the ID-custom-scalar branch May 20, 2024 19:30
BobaFetters pushed a commit that referenced this pull request May 20, 2024
BobaFetters pushed a commit to apollographql/apollo-ios-codegen that referenced this pull request May 20, 2024
BobaFetters pushed a commit that referenced this pull request May 20, 2024
e440cb50 Support ID scalar as a custom scalar (#363)

git-subtree-dir: apollo-ios-codegen
git-subtree-split: e440cb505958f9b7aca8c8a570d18a1e95044a8a
BobaFetters pushed a commit that referenced this pull request May 20, 2024
…calar

git-subtree-dir: apollo-ios-codegen
git-subtree-mainline: ccfb72e
git-subtree-split: e440cb505958f9b7aca8c8a570d18a1e95044a8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ID as a custom scalar
2 participants