-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ID scalar as a custom scalar #363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
This looks good, thanks for doing it so quickly. It seems to be failing on one of the codegen test configurations though. 🤔 |
calvincestari
approved these changes
May 17, 2024
AnthonyMDev
force-pushed
the
ID-custom-scalar
branch
from
May 20, 2024 19:23
b4b5831
to
ce755b2
Compare
BobaFetters
pushed a commit
that referenced
this pull request
May 20, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
May 20, 2024
BobaFetters
pushed a commit
that referenced
this pull request
May 20, 2024
e440cb50 Support ID scalar as a custom scalar (#363) git-subtree-dir: apollo-ios-codegen git-subtree-split: e440cb505958f9b7aca8c8a570d18a1e95044a8a
BobaFetters
pushed a commit
that referenced
this pull request
May 20, 2024
…calar git-subtree-dir: apollo-ios-codegen git-subtree-mainline: ccfb72e git-subtree-split: e440cb505958f9b7aca8c8a570d18a1e95044a8a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the generation of the ID scalar to be treated as a custom scalar that can be modified by the user.
This is implemented by request from #3379.