[ApolloPagination] Make isLoadingAll publicly accessible, remove special logic
#371
+60
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
👷 Deploy request for eclectic-pie-88a2ba pending review.Visit the deploys page to approve it
|
Iron-Ham
changed the title
isLoadingAll publicly accessibleisLoadingAll publicly accessible
Iron-Ham
changed the title
isLoadingAll publicly accessibleisLoadingAll publicly accessible, remove special logic around isLoadingAl
Iron-Ham
changed the title
isLoadingAll publicly accessible, remove special logic around isLoadingAlisLoadingAll publicly accessible, remove special logic around isLoadingAll
Iron-Ham
changed the title
isLoadingAll publicly accessible, remove special logic around isLoadingAllisLoadingAll publicly accessible, remove special logic
|
Let's continue to discuss the desired behavior for this in #3387 before deciding on how to proceed here. |
|
@Iron-Ham - is this still dependent on work being done in other issues/PRs, is there anything you need from us here? |
|
@calvincestari I think this is still the right thing to do – but I can re-open this after #428 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
This is a breaking change!
This pull request introduces the
isLoadingAllproperty to bothGraphQLQueryPagerandAsyncGraphQLQueryPager. Additionally, it removes the logic in theAsyncGraphQLQueryPagerCoordinator'ssubscribefunction which intentionally does not forward updates to subscribers whileloadingAll.The existing logic was built on the assumption that callers of
loadAllwill not want any updates until we can furnish all data. However, with a publicisLoadingAllproperty, consumers of the API can manage this behavior themselves. This does mean that users will receive each page as it comes in via theloadAllfunction unless they specifically want to defer the update (through use of theisLoadingAllproperty).