defer: Refactor execution for deferred fragment cache reads #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
commented
Jun 14, 2024
apollo-ios/Sources/Apollo/ExecutionSources/NetworkResponseExecutionSource.swift
Show resolved
Hide resolved
calvincestari
force-pushed
the
defer/cache-read-execution
branch
from
d25bb8d to
539394f
Compare
calvincestari
commented
Jun 18, 2024
| if executionSource.shouldAttemptDeferredFragmentExecution { | ||
| for deferredFragment in groupedFields.deferredFragments { | ||
| guard let fragmentType = groupedFields.cachedFragmentIdentifiers[deferredFragment] else { | ||
| info.deferredFragments.insert(deferredFragment) |
There was a problem hiding this comment.
In the case that the fragment type cannot be found in the cache I think it's best that it remains 'deferred'; it's not going to break execution.
calvincestari
commented
Jun 18, 2024
calvincestari
force-pushed
the
defer/cache-read-execution
branch
from
d6d1292 to
0e63ba9
Compare
AnthonyMDev
approved these changes
Jun 20, 2024
apollo-ios/Sources/Apollo/ExecutionSources/NetworkResponseExecutionSource.swift
Show resolved
Hide resolved
calvincestari
merged commit 278efa4
into
feature/defer-execution-networking
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset enables cache-based execution of operations that use
@defer. Since there is only a single response from a cache read all available deferred fragments will be returned with the initial (partial) data. Any deferred fragments that cannot be fulfilled will remain as 'deferred' in the result.The executor now enumerates through deferred fragments that were collected into
_deferredFragments, matches the identifier to a fragment cache entry, and attempts to immediately resolve the fragment fields. If successful then the deferred fragment is marked as fulfilled. If the deferred fragment cannot resolved because of something such as a missing field, then the fragment remains as 'deferred' in the result.