Fix a leak related to use of function used in a closure #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prabhuamol: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for eclectic-pie-88a2ba pending review.Visit the deploys page to approve it
|
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
calvincestari
approved these changes
Aug 8, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Aug 8, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Aug 8, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Aug 8, 2024
7d0c7e9c Fix a leak related to use of function used in a closure (#457) git-subtree-dir: apollo-ios git-subtree-split: 7d0c7e9c70fa1cfeefa7196f14b2297eb97b448f
BobaFetters
pushed a commit
that referenced
this pull request
Aug 8, 2024
…sed in a closure git-subtree-dir: apollo-ios git-subtree-mainline: c3afbf4 git-subtree-split: 7d0c7e9c70fa1cfeefa7196f14b2297eb97b448f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a leak in fileprivate lazy var loader: DataLoader<CacheKey, Record> because the method implicitly uses self. Making the capture explicit and breaking the retain cycle here. This was also covered in WWDC 2024 analyze heap memory talk https://developer.apple.com/wwdc24/10173?time=1748
Leak detected via instruments
