enhancement: Set URLRequest cache policy on GET requests #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
BobaFetters
approved these changes
Sep 11, 2024
The only question I have is whether the following should ignore remote caches or not?
|
Yea I think thats a reasonable assumption that it should ignore anything cached on the iOS client side which is what Apollo iOS would be doing, but could still use remote cached responses. |
BobaFetters
pushed a commit
that referenced
this pull request
Sep 11, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Sep 11, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Sep 11, 2024
6620447d enhancement: Set URLRequest cache policy on GET requests (#476) git-subtree-dir: apollo-ios git-subtree-split: 6620447d66a270c5605529f0a51ccfdd5d9769c9
BobaFetters
pushed a commit
that referenced
this pull request
Sep 11, 2024
…y on GET requests git-subtree-dir: apollo-ios git-subtree-mainline: c9f0bfd git-subtree-split: 6620447d66a270c5605529f0a51ccfdd5d9769c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apollographql/apollo-ios#3432.
There is currently no way for a user to opt-out of the URLRequest default caching behaviour. This PR simply sets a comparable cache policy on
URLRequestforGETrequests.returnCacheDataElseFetch==returnCacheDataElseLoad: Direct comparisonfetchIgnoringCacheData==reloadIgnoringLocalCacheData: The Apollo iOS version of this cache policy means that only the request will ignore cached data but the response will still be cached. It seems correct to ignore any iOS cached responses but still use any remote (CDN) cached responses.fetchIgnoringCacheCompletely==reloadIgnoringLocalAndRemoteCacheData: The Apollo iOS version of this cache policy will ignore cached data for the request but it will also not cache any response data. The equivalentURLRequestpolicy here is to ignore all local (iOS) and remote (CDN) cached data and always go to the server for a response.returnCacheDataDontFetch==returnCacheDataDontLoad: Direct comparisonreturnCacheDataAndFetch==reloadRevalidatingCacheData: The Apollo iOS request chain will handle the return-cache-data portion of this policy but we extend that to any iOS cached responses, for and-fetch, by making iOS ensure any cached responses are still valid, otherwise fetch from the server.