ci: Fix URLSessionClientTest tests
#524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
calvincestari
changed the title
URLSessionClientTest tests
AnthonyMDev
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been getting frequent failures of the
test__request__cancellingTaskThroughClient_shouldNotCallCompletiontest in the Main Branch Health nightly build. I fixed the build logs not being archived which lead to the following:fatalErrorfor a missing request handler. I think it's a bad practice and the behaviour obscures the actual test failure by crashing instead.test__request__cancellingTaskThroughClient_shouldNotCallCompletiontest by invoking the same delegate callback that happens when a task is cancelled. This means we don't need to wait an arbitrary amount of time for the request callback to be called and can know for certain that the test succeeded.test__request__taskDescriptiontest by not having to wait an arbitrary amount of time for the test to exit. The test has nothing to do with the completion handler and the task description can be checked and the test satisfied immediately.