fix: GraphQLOperation hash uniqueness
#530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
calvincestari
commented
Oct 31, 2024
We shouldn't be testing for hash value explicitly. If there is a problem with hashing it'll shake out in data structures that rely on unique hash values.
AnthonyMDev
approved these changes
Oct 31, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Oct 31, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Oct 31, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Oct 31, 2024
0ae62c4c fix: `GraphQLOperation` hash uniqueness (#530) git-subtree-dir: apollo-ios git-subtree-split: 0ae62c4c8290cde92bbc63b42cfa09975a3afff5
BobaFetters
pushed a commit
that referenced
this pull request
Oct 31, 2024
git-subtree-dir: apollo-ios git-subtree-mainline: 712a20c git-subtree-split: 0ae62c4c8290cde92bbc63b42cfa09975a3afff5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3467.
Adding uniqueness to
GraphQLOperationhashing.