Add ability to get to Starscream's underlying SOCKS proxy property. #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KonstantinEfimenko Wanna take a look? |
designatednerd
commented
Mar 31, 2020
| return socket.enableSOCKSProxy | ||
| } | ||
| set { | ||
| guard var socket = self.websocket as? SOCKSProxyable else { |
There was a problem hiding this comment.
this has to be guard var as guard let wouldn't let me change enableSOCKSProxy since this protocol is not class-bound.
|
Looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1104. Definitely glad I went this way - it's not just that you have to set it on the web socket, you have to set it on the underlying stream. Ouch.
Anyway that's all abstracted away now so yay.