Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't retain WebSocketTransport during reconnect #1674

Merged
merged 1 commit into from
Feb 22, 2021
Merged

don't retain WebSocketTransport during reconnect #1674

merged 1 commit into from
Feb 22, 2021

Conversation

RolandasRazma
Copy link
Contributor

don't retain WebSocketTransport during reconnect

@designatednerd
Copy link
Contributor

I'm curious: Is this a defensive weak self or have you seen this be a problem?

@RolandasRazma
Copy link
Contributor Author

I did not seen any issues. I was looking into doing exponential backoff and retaining to reconnect if you reconnect time is big made no sense

@designatednerd
Copy link
Contributor

Makes a lot more sense in the context of exponential backoff, thank you!

@designatednerd designatednerd added this to the Next Release milestone Feb 22, 2021
@designatednerd designatednerd merged commit cd9a77b into apollographql:main Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designatednerd designatednerd designatednerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@RolandasRazma @designatednerd