Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace class constraint with AnyObject #1733

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

yhkaplan
Copy link
Contributor

Pretty insignificant, but the recommended practice in Swift now is to use AnyObject instead of class, and recently there have been motions toward a new reference type (actor) that the class naming makes a little unclear, while AnyObject is more of a generic and all-encompassing term for reference types. Also, the class constraint typealias may be removed in future versions of Swift.

ref: https://github.com/apple/swift-evolution/blob/master/proposals/0156-subclass-existentials.md#class-and-anyobject

@apollo-cla
Copy link

@yhkaplan: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@AnthonyMDev
Copy link
Contributor

LGTM! Thanks for the clean up!

@AnthonyMDev AnthonyMDev merged commit 2a79982 into apollographql:main Mar 26, 2021
@designatednerd designatednerd added this to the Next Release milestone Mar 26, 2021
@cltnschlosser
Copy link
Contributor

With Xcode 12.5 in RC now, it would be nice to get a version released with this warning fixed. Thanks!

@designatednerd
Copy link
Contributor

Hey - I'm working on some tests for some web socket stuff that was merged earlier today before I do a release but will try to get this out early next week.

@cltnschlosser
Copy link
Contributor

Hey - I'm working on some tests for some web socket stuff that was merged earlier today before I do a release but will try to get this out early next week.

Great, thanks!

@designatednerd
Copy link
Contributor

Guh, apple, why you gotta release Xcode on a Monday? will cut a release tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants