Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure SelectionSet field accessors are generated with swift camelCasing #2169

Merged
merged 26 commits into from
Feb 22, 2022
Merged

Ensure SelectionSet field accessors are generated with swift camelCasing #2169

merged 26 commits into from
Feb 22, 2022

Conversation

AnthonyMDev
Copy link
Contributor

Fixes #2167.

@AnthonyMDev
Render Operation Variable - single variable
1e1a6e9
@AnthonyMDev
Operation Variables - Multiple Variables
35a5272
@AnthonyMDev
WIP: Operation Variable - nullables
b2770a7
@AnthonyMDev
Recfactored to add InputValueRenderable
f9dcc92 
Finished implementation of operation variable generation
@AnthonyMDev
Fix renamed but not deleted file
9006ab9
@AnthonyMDev
Add ExpressibleBy Literals to GraphQLNullable
b5864cb
@AnthonyMDev
Correct OperationVariable rendering test behavior
110a6bf
@AnthonyMDev
WIP: Implementing rendering
14a0989
@AnthonyMDev
Fix template string indentation
fedc884
@AnthonyMDev
Add operation variable default values to CompilationResult
3c2c08c
@AnthonyMDev
Add pet adoption mutation
001a49a
@AnthonyMDev
Add public modifier to input object template
6af18f7
@AnthonyMDev
WIP: Fixing Input Object Accessors
eda88fb
@AnthonyMDev
Add public to input object init and fields
df531ec
@AnthonyMDev
Generate InputObject fields with dynamic member accessors
e49a422
@AnthonyMDev
Rename input object "dict" to "data"
99b65b6
@AnthonyMDev
Added PetSearchQuery to AnimalKingdom API
b7b56bb
@AnthonyMDev
Fixed rendering of input enum values
6528aec
@AnthonyMDev
Fixed conversion of default value dictionary literal to InputObject
6650fff
@AnthonyMDev
WIP
2a18a8a
@AnthonyMDev
Restructured tests to be accurate for behavior with initializing inpu…
ba9c640 
…it object default values directly
@AnthonyMDev
Changed Implementation for direct input value initialization
3c105a1
@AnthonyMDev
WIP: FieldArgument Rendering
224eda6
@AnthonyMDev
Fix field argument rendering to use literals
3c780f3
@AnthonyMDev
Regenerate AnimalKingdomAPI with field arguments
ddd74ac
@AnthonyMDev
Ensure SelectionSet field accessors are generated with swift camelCasing
5a0cf89
@AnthonyMDev AnthonyMDev added this to the Release 1.0 (Alpha) milestone Feb 21, 2022
calvincestari
calvincestari approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@calvincestari calvincestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from 1.0/operation-variables to release/1.0-alpha-incubating February 22, 2022 20:05
@AnthonyMDev AnthonyMDev merged commit 8a1dd73 into release/1.0-alpha-incubating Feb 22, 2022
@AnthonyMDev AnthonyMDev deleted the 1.0/field-name-lowercased branch February 22, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincestari calvincestari calvincestari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.0 (Alpha)
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyMDev @calvincestari