-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Union test mock generator #2298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@AnthonyMDev let's discuss this again in the morning but I think generating the union test mock extensions may be the best solution. |
AnthonyMDev
approved these changes
Jun 7, 2022
Looks like you've got a test that needs updating, but otherwise I'm good to ship this! |
✅ Deploy Preview for apollo-ios-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ApolloTestSupport
package.Union
types that conform toMockFieldValue
.Alternatives solutions for
Union
conforming toMockFieldValue
Union
protocol declaration to add conformance toMockFieldValue
; the extension then to implement the typealias can be in that file or elsewhere. The problem with this approach is thatMockFieldValue
referencesAnyMock
and attempting toimport ApolloTestSupport
creates a circular dependency. Bringing theAnyMock
declaration intoApolloAPI
resolves build errors inUnion.swift
but makesUnion
unusable inParentType
because of the associated type requirement -Protocol 'Union' can only be used as a generic constraint because it has Self or associated type requirements
.