Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all instances of bitcode as it's not supported in Xcode 14 #2398

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Remove all instances of bitcode as it's not supported in Xcode 14 #2398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Configuration/Apollo/Apollo-Project-Performance-Testing.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@
ONLY_ACTIVE_ARCH = YES

COPY_PHASE_STRIP = NO
ENABLE_BITCODE = NO
ENABLE_TESTABILITY = YES
1 change: 0 additions & 1 deletion Configuration/Apollo/Apollo-Target-TestHost-iOS.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ SDKROOT = iphoneos
SUPPORTED_PLATFORMS = iphonesimulator iphoneos

ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES
ENABLE_BITCODE = NO

INFOPLIST_FILE = Tests/TestHost iOS/Info.plist
PRODUCT_BUNDLE_IDENTIFIER = com.apollographql.$(PRODUCT_NAME:rfc1034identifier)
Expand Down
1 change: 0 additions & 1 deletion Configuration/Shared/Workspace-Target-Codegen.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
SDKROOT = macosx
SUPPORTED_PLATFORMS = macosx

ENABLE_BITCODE = NO
3 changes: 0 additions & 3 deletions Configuration/Shared/Workspace-Target-Test.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// Packaging
WRAPPER_EXTENSION = xctest

// Code Generation
ENABLE_BITCODE = NO

// Disable some known troublesome warnings for the test target, as -Weverything without these exceptions causes errors when importing XCTest
WARNING_CFLAGS = $(inherited) -Wno-documentation-unknown-command -Wno-incomplete-module -Wno-disabled-macro-expansion -Wno-shadow

Expand Down
11 changes: 0 additions & 11 deletions Configuration/Shared/Workspace-Universal-Framework.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,3 @@ TARGETED_DEVICE_FAMILY[sdk=watch*] = 4
SDKROOT[sdk=macosx*] = macosx
SUPPORTS_MACCATALYST = YES

// Enable Bitcode only for actual devices, not for macOS or simulators
ENABLE_BITCODE[sdk=watchos*][config=Release] = YES
ENABLE_BITCODE[sdk=iphoneos*][config=Release] = YES
ENABLE_BITCODE[sdk=appletvos*][config=Release] = YES

// By default, BITCODE_GENERATION_MODE is "marker".
// Based on Realm's fix for Bitcode, this needs to be "bitcode"
// Source: https://github.com/realm/realm-cocoa/pull/2567
BITCODE_GENERATION_MODE[sdk=watchos*][config=Release] = bitcode
BITCODE_GENERATION_MODE[sdk=iphoneos*][config=Release] = bitcode
BITCODE_GENERATION_MODE[sdk=appletvos*][config=Release] = bitcode