fix: Throw error when no schema nor operation files are found #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
calvincestari
commented
Oct 27, 2022
| @@ -56,12 +62,14 @@ public class ApolloCodegen { | |||
| rootURL: rootURL | |||
| ) | |||
|
|
|||
| try validate(config: configContext) | |||
There was a problem hiding this comment.
I've separated these two validate calls because the first one includes path syntax validation and should be done before compilation of the schema + operations. The second validation (line 72) ensures no schema name conflict.
I don't like that they're now separate, some ideas to improve:
- rename the second one from
validateto something else - move the schema name logic somewhere else
calvincestari
commented
Oct 27, 2022
| @@ -191,7 +191,7 @@ public struct Glob { | |||
| globfree(&globT) | |||
| } | |||
|
|
|||
| CodegenLogger.log("Matching \(pattern)", logLevel: .debug) | |||
| CodegenLogger.log("Evaluating \(pattern)", logLevel: .debug) | |||
There was a problem hiding this comment.
Matching was too close to Matched. Evaluating is more indicative of what the logic is actually doing.
calvincestari
force-pushed
the
fix/codegen-error-responses
branch
from
7899de8
to
8d66723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2567
When a schema file could not be found graphql-js would emit errors but they were not indicative of the underlying problem. I've added validation to ensure that at least one match of the schema/operation search paths is found otherwise an error is thrown.