fix: fields labeled _
#2769
Merged
fix: fields labeled _
#2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docs canceled.
|
|
@AnthonyMDev the input objects and mocks work as expected but the initializer provided by autocomplete lacks backticks around the Let's talk about it tomorrow. I'm not sure how I feel about it since it's not a great user experience but I feel it's better than simply disallowing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2753
This PR brings back the
_character as an allowed field name. Removing it fromDisallowedFieldNamesand adding it toFieldAccessorNamesToEscapecauses it to be escaped as expected in all property and initializer definitions.This functionality is dependent on #2759 being fixed too.