Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removes backticks from subscript keys #2773

Merged
merged 1 commit into from
Jan 12, 2023
Merged

fix: Removes backticks from subscript keys #2773

merged 1 commit into from
Jan 12, 2023

Conversation

calvincestari
Copy link
Member

Fixes #2759

Removes the backticks from subscript keys of input objects.

@netlify
Copy link

netlify bot commented Jan 12, 2023 •
edited
Loading

✅ Deploy Preview for apollo-ios-docs canceled.

Name Link
🔨 Latest commit f271457
🔍 Latest deploy log https://app.netlify.com/sites/apollo-ios-docs/deploys/63bf59792b650700081b7917

AnthonyMDev
AnthonyMDev approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@calvincestari calvincestari merged commit 6ba4e59 into main Jan 12, 2023
@calvincestari calvincestari deleted the fix/escaped-subscript-keys branch January 12, 2023 20:53
@calvincestari calvincestari mentioned this pull request Jan 31, 2023
Closed
@calvincestari calvincestari mentioned this pull request Feb 8, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyMDev AnthonyMDev AnthonyMDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subscript GraphQL variable from dictionary crash when Swift modifier used as key.
2 participants
@calvincestari @AnthonyMDev