Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SQLiteNormalizedCache for Swift 5 #561

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Update SQLiteNormalizedCache for Swift 5 #561

merged 1 commit into from
Jun 25, 2019

Conversation

nh7a
Copy link
Contributor

@nh7a nh7a commented May 31, 2019

I just realized everything in master works fine with Swift 5 except SQLiteNormalizedCache.
Let's replace deprecated index(of:) with firstIndex(of:) so that Xcode 10.2 doesn't have to offer an upgrade any more.

designatednerd
designatednerd approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@designatednerd designatednerd merged commit 3bb654a into apollographql:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designatednerd designatednerd designatednerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nh7a @designatednerd