-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApolloSQLite and ApolloWebSockets to Package.swift #674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I was literally about to put this on my checklist for this week.
Would you mind (if you haven't already) checking that this builds and compiles generated code? I should have mentioned this in the description, but I uh forgot 😬 : I was unable to verify that this works, cause I was having problems using the code gen with my weird Swift backend. I got to a certain point and started running into some name clashing errors. Hold off on merging one minute, lemme pull up the branch. |
Here it is, it's a runtime error in
I assumed it was just an issue with my setup and didn't pursue it further, and then forgot I had put up the PR. I'm wondering now if it could also be an SPM issue, but I don't have a handy schema to test with. Sorry to push untested work, it was real late! 😦 |
OK - I'll take a look tomorrow! I'm gonna mark this as changes requested so I don't accidentally merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to make sure this is building properly
Gonna take another swing through this for |
OK! I was able to confirm this is working in Xcode 11b5 with the attached dummy project - run it and you'll see both web sockets and sqlite working nicely! |
This exposes the ApolloSQLite and ApolloWebSockets sub-frameworks to clients.
This comes after I tried to set up disk-caching and realized
SQLiteNormalizedCache
wasn't available for use in SPM, although it was for Carthage and Cocoapods. I also included ApolloWebSockets since it seemed to be in the same situation.