Support Auto-Persisted Queries #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. remove `_` on private variable 3. add guard clause to optional variable in HttpNetworkTransportTests 4. removed redundant parameter in StarWarsServerTests 5. change // Mark to // MARK 6. single line for method declaration 7. removed redundant code in HTTPNetworkTransport 9. update switch style
…former for SDK lower than 11.
renamed useHttpGetMethodForPersistedQueries to useGETForPersistedQueryRetry un-shared test projects fixed grammer typo in GraphQLHTTPResponseError updated to use XCTAssertEqual
# Conflicts: # Apollo.xcodeproj/project.pbxproj # Sources/Apollo/GraphQLGETTransformer.swift # Sources/Apollo/HTTPNetworkTransport.swift # Tests/ApolloTests/GETTransformerTests.swift # Tests/StarWarsAPI/API.swift
This was referenced Sep 16, 2019
|
This is now waiting on some changes to tooling |
# Conflicts: # Apollo.xcodeproj/project.pbxproj # Sources/Apollo/HTTPNetworkTransport.swift # Sources/Apollo/RequestCreator.swift
# Conflicts: # Apollo.xcodeproj/project.pbxproj # Sources/Apollo/RequestCreator.swift # Tests/ApolloTests/GETTransformerTests.swift # Tests/ApolloTests/RequestCreatorTests.swift # Tests/StarWarsAPI/API.swift
|
Okay! Will need to merge this again once #821 gets merged, but this shouuuuuuld be about ready to go |
|
This is really great. ❤️ So far I guess we can look at the test files for examples, but are there any plans to add a section in the docs regarding how to set this up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update of work started in #608. However, we're running into an issue where stripping whitespace out of queries is causing APQ validation to fail, because the SHA256 hash no longer matches. I need to figure out if there's a way around this or if I need to just suck it up and use multiline string literals (cc @lilyball).
Leaving this in draft until I can figure out, but @Codebear98 would love feedback on some of the restructuring I did in the merge.