Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wasmJs #21

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add support for wasmJs #21

merged 1 commit into from
Jan 15, 2025

Conversation

farmerbb
Copy link
Contributor

@farmerbb farmerbb commented Jan 8, 2025

Adds basic support for compiling to wasmJs for use with Kotlin/Wasm apps running via Node.js.

Notes:

  • Created a jsCommon group following the same pattern as in the apollo-kotlin repo, and moved KtorHttpEngine.js.kt to there.
  • I also moved all-tests.kt to noWasmTest as the tests fail to run under Wasm.

@apollo-cla
Copy link

@farmerbb: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Collaborator

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@farmerbb
Copy link
Contributor Author

@martinbonnin Is there anything else I can assist with for this to get merged? I've already signed the CLA.

@martinbonnin
Copy link
Collaborator

Thank you for the ping, it's all good ✅ Thanks again for the contribution!

@martinbonnin martinbonnin merged commit c554ab9 into apollographql:main Jan 15, 2025
2 checks passed
@martinbonnin
Copy link
Collaborator

I just kicked the release, 0.1.1 should be out on Maven Central soon: https://github.com/apollographql/apollo-kotlin-ktor-support/actions/runs/12794821645/job/35670787125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants