ApolloClient.Builder.okHttpClient() returns null instead of this

[japhib]

Version

main

Summary

This code:

new ApolloClient.Builder().okHttpClient(okHttpClient()).build()

throws a NullPointerException because the okHttpClient setter method on ApolloClient.Builder returns null rather than this.

The javadoc for that method says this:

@return The {@link Builder} object to be used for chaining method calls

which makes it seem like a typo.

Steps to reproduce the behavior

Run new ApolloClient.Builder().okHttpClient(new OkHttpClient()).build() and observe that a NullPointerException is thrown.

Logs

No response

[japhib]

PR: #5778

[BoD]

Fixed in 3.8.4

[github-actions]

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Kotlin usage and allow us to serve you better.