Differentiate escaping of Java or Kotlin keywords #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoD
requested review from
martinbonnin,
sav007 and
tasomaniac
as code owners
BoD
commented
Nov 30, 2021
| @@ -37,7 +37,7 @@ public class TestQuery() : Query<TestQuery.Data> { | |||
| public override fun selections(): List<CompiledSelection> = TestQuerySelections.root | |||
|
|
|||
| public data class Data( | |||
| public val enum_: Enum? | |||
| public val `enum`: Enum? | |||
There was a problem hiding this comment.
I must admit I don't understand this one. Is this KotlinPoet automatically escaping it? If yes why is it not done in other places?
There was a problem hiding this comment.
Relevant PR from kotlinpoet: square/kotlinpoet#994
Feels weird escaping in both Apollo + KotlinPoet but I'm not sure we can rely 100% on KotlinPoet because we might use identifiers in places where KotlinPoet doesn't know enough context to escape?
Things like:
CodeBlock.of("%L.value", layout.fieldName(responseName))Might be worth trying to remove all escaping from Apollo and give KotlinPoet the proper hints?
apollo-compiler/src/main/kotlin/com/apollographql/apollo3/compiler/ReservedKeywords.kt
Outdated
Show resolved
Hide resolved
apollo-compiler/src/test/graphql/com/example/reserved_keywords/TestOperation.graphql
Show resolved
Hide resolved
BoD
force-pushed
the
escape-java-or-kotlin-keywords
branch
from
c6f7975 to
fdffe2d
Compare
martinbonnin
reviewed
Dec 1, 2021
martinbonnin
reviewed
Dec 1, 2021
martinbonnin
reviewed
Dec 1, 2021
...ler/src/main/kotlin/com/apollographql/apollo3/compiler/codegen/kotlin/KotlinCodegenLayout.kt
Outdated
Show resolved
Hide resolved
martinbonnin
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.