Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IJ Plugin: add settings #4651

Merged
merged 8 commits into from
Jan 31, 2023
Merged

IJ Plugin: add settings #4651

merged 8 commits into from
Jan 31, 2023

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Jan 23, 2023

Screenshot 2023-01-30 at 11 28 22

Also refactor: split project service in 2 services: ApolloProjectService / ApolloCodegenService and move files around a bit.

PS: tried to use Compose but currently blocked because of this issue which keeps our UI visible even when switching to another tab

@BoD BoD requested a review from martinbonnin as a code owner January 23, 2023 19:26
@netlify
Copy link

netlify bot commented Jan 23, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 30661c4
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/63d79c168bfc3a0008089418

@BoD BoD changed the title Add Settings State, Configurable and Component IJ Plugin: add settings Jan 25, 2023
@@ -16,3 +16,7 @@ action.ApolloV2ToV3MigrationAction.confirmDialog.message=This will migrate your
ApolloV2ToV3MigrationProcessor.title=Migrate to Apollo Kotlin 3
ApolloV2ToV3MigrationProcessor.codeReferences=Items to be migrated
ApolloV2ToV3MigrationProcessor.noUsage=No Apollo Android 2 references found in the project

settings.codegen.automaticCodegenTriggering.text=Automatic code generation
settings.codegen.automaticCodegenTriggering.comment=Automatically regenerate the models when GraphQL files are edited
Copy link
Contributor

@martinbonnin martinbonnin Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth going more in-depth in the explanation?

When this option is active, the plugin will run Gradle in continuous mode, 
similarly to `./gradlew generateApolloSources --continuous`. This watches
 changes to your GraphQL files and re-generates models when they change.

@BoD BoD merged commit 775a106 into main Jan 31, 2023
@BoD BoD deleted the ij-plugin-settings branch January 31, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants