[IJ Plugin] Add 'Input class constructor issue' inspection #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
reviewed
Dec 4, 2023
intellij-plugin/src/main/resources/inspectionDescriptions/ApolloInputConstructorNamedArgs.html
Outdated
Show resolved
Hide resolved
intellij-plugin/src/main/resources/inspectionDescriptions/ApolloInputConstructorNamedArgs.html
Outdated
Show resolved
Hide resolved
intellij-plugin/src/main/resources/inspectionDescriptions/ApolloInputConstructorNamedArgs.html
Outdated
Show resolved
Hide resolved
intellij-plugin/src/main/resources/inspectionDescriptions/ApolloInputConstructorNamedArgs.html
Outdated
Show resolved
Hide resolved
| implementationClass="com.apollographql.ijplugin.inspection.ApolloInputConstructorNamedArgsInspection" | ||
| groupPathKey="inspection.group.graphql" | ||
| groupKey="inspection.group.graphql.apolloKotlin" | ||
| key="inspection.inputConstructorNamedArgs.displayName" |
There was a problem hiding this comment.
Can there be a description that explains the issue in more depth?
intellij-plugin/src/main/resources/messages/ApolloBundle.properties
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Bonnin <martin@mbonnin.net>
martinbonnin
approved these changes
Dec 5, 2023
martinbonnin
reviewed
Dec 5, 2023
Comment on lines
+12
to
+13
| context(LocalInspectionTool) | ||
| fun ProblemsHolder.registerProblem( |
There was a problem hiding this comment.
🤯 Do we have context receivers in the codebase now?
There was a problem hiding this comment.
Ahaha yeah actually I've used them before in the plugin code 😅
There was a problem hiding this comment.
Plugin is probably OK but I'm not sure about the compatibility implication of those so I'd rather not use them in the libs
There was a problem hiding this comment.
Agreed 👍 We have a bit more leeway in the plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-12-04.at.19.15.58.mov
Fix for #5374